reimplementing SANE-USER-FLAGS and other things #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o add to it from man 7 notify on IN_MASK_ADD: add (OR) the events in mask to the watch mask (instead of replacing the mask)
This led to the error: The value of SYMBOL is (:MASK-ADD :MOVE-SELF), which is not of type SYMBOL.
…N_MASK_ADD at all The existing code used :MASK-ADD when REPLACE-P was T, which would not replace but OR the flags. So this part was inverted. Nevertheless, if there was a watch already configured the code would always UNION with the previous flags, so that flags would never be replaced.
Owner
|
Hi Max, I'll check it out, thanks for the PR already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Olof-Joachim,
We noticed that replace-p actually does not work as documented.
You might want to look at this or just ignore it.
With greetings from the Engelbecken in Berlin,
Max